Nothing major happening here...#2
Open
gnlnx wants to merge 2 commits into10n1:masterfrom
gnlnx:master
Open
Conversation
Member
Author
|
very interesting...and odd. I guess I don't know how git(hub) works I created the pull request when only the "a17a03f" commit existed on my forked verison. I fetched/merged your changes "adding device" and it automatically added that commit to the pull request. I wasn't expecting that but not sure how how to remove it. |
Member
Author
|
I should really read stuff before commenting :D This is expected behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some leftover comment changes in my local repo.